Skins: |

NWN SCRIPTS

- Jump to comments -

Title

No Ability Stacking v 2.2

Author

YellowLab

Submitted / Updated

07-14-2003 / 11-22-2006

Category

Rulesets

Expansions

NWN-1.61

View Code

No Ability Stacking for Items, Spells, and Potions
Version 2.2

README

REVISION HISTORY:
v. 1.0   Created July 2003
v. 2.0   Updated January 2004
   Redesigned utilizing new scripting functions in version 1.61
   Changes to yl_i0_noabstack:
    *  added some YL_* constants
    *  redeisinged the "FindModifiers" function using GetItemProperty fucntions
       instead of forcing the player to equip and watch the changes.
       THIS IS MUCH MORE EFFICIENT, LESS CPU INTENSIVE AND LESS NOTICABLE
       TO THE PLAYER!!!
    *  added function int BioToYL which converts Bioware's Ability values to
       YellowLab's values
   Changes to Spell Functions, nw_s0_*:
    *  replaced numerical value with appropriate YL_* constant
   Changes to yl_nas_acquire
    *  greatly simplified this script.  Only runs FindModifiers function which
       evaluates the item and stores the modifications on the object
   Changed yl_nas_heartbeat to yl_nas_itemchng
    *  the heartbeat script is no longer necessary.  This fucntionality is handled
       OnPCItemEquip, OnPCItemUnequip, OnRest, and when certain spells are cast
    *  Various code modifications using version 1.61 script functions
    *  THIS IS MUCH MORE EFFICIENT AND LESS CPU INTENSIVE!!!
   Added yl_nas_equip
   Added yl_nas_rest
   Added yl_nas_unequip
   Added yl_nas_unacquire
   Removed yl_nas_levelup
v. 2.1  Updated January 2004
   Fixed critical implementation error in instructions.
   Thanks to Meraxes for the catch!
v. 2.2  Updated January 2004
   Fixed all spells to be truly 1.61 compliant
    *  Added SpellCast Hook Code and Include Files
    *  Bull's Strength and Greater Bull's Strength had some issues fixed due to Blackguard feats
   Added Divine Power to be included in the No Stack Rules
     Thanks to NoMercy for bringing this to my attention

BACKGROUND:
Thank you for downloading my script set.

This script set was designed from an issue that ability stats using the Aurora Engine
are stackable, but according to the PHB they shouldn't be.  In addition, spells
with ability enhancements stack with the already stacked item abilities.
That is also a no-no.

For instance, if you have a Ring of Strength (STR +1) and a Belt of Ogre Strength
(STR +2) equipped, your modification should be STR +2 not STR +3.  If you then use
a potion of Bull's Strength and it gives you a temporary strength modification of +3,
while the potion is active, your strength should only be modified +3, not +6.  Once the
potion wears off, the modification would return to +2.

HOW IT WORKS:
The script starts OnAcquire of any item.  If it has "ITEM_PROPERTY_ABILITY_BONUS"
the stat changes noted as an array of variables on the object.  At Equip and Unequip
of items, the script checks to see if the item being Equipped or Unequipped has
the "ITEM_PROPERTY_ABILITY_BONUS".  If so, it finds what slot it is going to / came from
notes this as a bit mask on the PC.  This bit mask can tell what slots have these items
equipped.  If there is a change, i.e. a new item is going on or coming off, then
the itemchange script if fired which determines the maximum value allowed for that
stat - if the current stat is to high (i.e. multiple items with the same value)
then an appropriate EffectAbilityDecrease is applied.  Once the conflict is resolved,
the effect is removed.

All appropriate spells have been modified so the script set knows when one is
cast and what the property is.  This includes potions since they are items that cast
specific spells.  The engine is already programmed for spells to be non-stackable
to each other, however these effects could stack with items.  This script set fixes that.
Again, the check is made (the potion essentially is treated as an equipped item).
During resting, applied effects are removed, and all of the appropriate checks are
completed (item stacking penalties are reapplied if necessary).

For further customization, i.e user created spells which modify abilities, include the
yl_i0_noabstack include file and the following code:

    if(!GetIsAbilityClear(TARGET,ABILTIY,MODIFIER))
    {
    FloatingTextStringOnCreature("Spell Modification Cannot Stack - Spell Lost",TARGET);
    return;
    }
    //Effect will be treated like new item and Ability Decrease Applied if necessary
    SetSpellValues(TARGET,ABILTIY,MODIFIER,DURATION);

Read the instructions for implementation and known issues below.
If other issues are found or enhancements desired please post here,
PM on the BioBoards (callsign YellowLab), or email me at
eandbflaherty@worldnet.att.net

Please use this script as you wish, but give me credit if you do.
Have fun...
YellowLab

////////////////////////////////////////////////////////////////////////////////
********************************************************************************
////////////////////////////////////////////////////////////////////////////////
INSTRUCTIONS:
To get this script set to work:
Import the following scripts via the erf
yl_i0_noabstack
yl_nas_acquire
yl_nas_equip
yl_nas_itemchng
yl_nas_rest
yl_nas_unacquire
yl_nas_unequip
nw_s0_bullstr
nw_s0_catgrace
nw_s0_divpower
nw_s0_eaglespl
nw_s0_endurce
nw_s0_foxcunng
nw_s0_grbullstr
nw_s0_grcatsgr
nw_s0_greaglesp
nw_s0_grendur
nw_s0_grfoxscu
nw_s0_growlwis
nw_s0_owlwis
these instructions will also be imported as yl_nas_aaareadme

Place this line in your OnAcquire:
   ExecuteScript("yl_nas_acquire",GetModuleItemAcquired());

Place this line in your OnPlayerEquipItem:
   ExecuteScript("yl_nas_equip",GetPCItemLastEquippedBy());

Place this line in your OnPlayerRest:
   ExecuteScript("yl_nas_rest",GetLastPCRested());

Place this line in your OnPlayerUnEquipItem:
   ExecuteScript("yl_nas_unequip",GetPCItemLastUnequippedBy());

Place this line in your OnUnacquire:
   ExecuteScript("yl_nas_unacquire",GetModuleItemLost());

////////////////////////////////////////////////////////////////////////////////
********************************************************************************
////////////////////////////////////////////////////////////////////////////////

KNOWN ISSUES
A script set such as this isn't perfect - far from it.
Here are a list of concerns (some have now been addressed with new features):

Since this script operates on the heartbeat there is a slight delay when stats
are correctly modified.  This could be fixed by putting all these functions into
UserDefined events and running them more often - but that may be even more CPU
taxing.  And there will still be some sort of delay unless it is run nearly
constantly.
(Level of difficulty to fix - moderate)
FIXED IN VERSION 2.0 WITH ADDITION OF OnPlayerEquipItem / OnPlayerUnEquipItem HANDLES

Ability Stats can only go up to 28 (prior to 1.61 this limit was 22), if a stat
theoretically goes over 28, the penalty will not be accurate due to how the script
assesses the penalty.  Essentially, the script set doesn't know the base abilities
of the PC.
This could be scripted as a OnClientEnter or OnModuleEnter or on a start trigger
and an OnPlayerLevelUp when new abiliites are given.  All ability increasing items
would need to be tallied and the player's base stats stored (and updated OnPlayerLevelUp).
Some scripts would need to run to determine if the total modificaiton excedes 28 and
reasess the penalty appropriately if this is the case.
(Level of difficulty to fix - moderate to hard)
THIS MAY BE EAISER TO FIX WITH THE NEW SCRIPT COMMANDS.  WILL LOOK INTO THIS.

The script set uses the OnAcquire script to determine the ability bonus types by
equipping the item in an appropriate spot.  This causes a slight delay in the item
showing up in the inventory as well as a double ping due to the item being equipped.
For weapons, this also means the equip animation will play, twice.  If multiple
items are taken quickly from the loot pile, one may remain equipped (if nothing
was equipped prior).  I have tweaked the dealy time as little as possible to
allow for weapons to be equipped / unequipped - this is 0.5 seconds.
Since the script tries to equip an item, if it is unequipable due to restrictions
a message will be sent to the PC that the item can't be equipped.
(Level of difficulty to fix - unknown to impossible)
FIXED IN VERSION 2.0 WITH ADDITION OF "ITEM PROPERTY TYPE" SCRIPT COMMANDS

Spells are already non-stackable.  Therefore - first come, first serve - even if
later spell has higher abilities.
(Level of difficulty to fix - unknown to impossible)

A bizarre thing happens when these stat skills are stored on an object, if the
object is dropped on the ground it becomes a pointer to the PC who last possessed it.
This is really bizarre as you can right click on the "object" and open a radial menu
and check the PC's stats.
(Level of difficulty to fix - unknown to impossible)
A workaround has been done which deletes the variable on the object seems to work.
This has not been tested completely.

Another bizarre thing happens when a potion is used, a rest event is created.
Why???? I don't know.  The work around is in the unacquire - a variable is stored
on the PC that had the rest event and this is checked on heartbeat.
(Level of difficulty to fix - unknown to impossible)

All EFFECT_TYPE_ABILITY_DECREASE effects are created by the module.  If other effects
of this type are created by the module, then they will be dispelled when items
are shifted.
(Level of difficulty to fix - easy.)
Some object must be the creator - the module is a very rare creator of effects
all spell effects are created by the caster - for potions the creator is the user)

Select All Text | View Code in separate window

Format

Code Only

Type

Type - Classic PnP

Includes

Custom

Description

This script has had a major rework to utilize the new script commands in version 1.60+. Included is an .erf file with the script set (yl_nostack.erf), a small mod demonstrating the script set (yl_stackable.mod), and a readme file. The .erf and .mod are flagged SOU only. I have also included a zipped file which contains all of the .nss source files. These can be opened with any text editor and then copied and pasted into the toolset to work in classic NWN or HotU only. Please see the readme for further information.

Files

Name	Type	Size	Downloads
nostack22.zipnostack22.zip Submitted: 07-14-2003 / Last Updated: 01-16-2004	zip	80.37Kb	348
--

SCORE OUT OF 10

10
1 votes
View Stats
Cast Your Vote!

PORTFOLIO

Add this entry to your portfolio so you can track it

Manage your existing portfolios or create a new one.

SCREENS

No Images

You Must Be Logged In to Participate.

Comments (18):

Posted by Arminath at 2004-07-22 20:03:00

Ok, thanks. I'll test it and see what happens.

Posted by YellowLab at 2004-07-21 12:23:00

I am pretty sure this will work with 1.62 (I think I tested it with that patch). I haven't tested it with HotU; however, the patch 1.62 changed all of the caps for the previous versions as well. As far as I know the 28 stat cap is a hard cap. If it is not, it will not affect the script since there is nothing in it to take care of that cap. Things just don't work as planned near the cap.

YL

Posted by Arminath at 2004-06-28 10:19:00

Also, was the Ability Score cap raised? I see in yout readme that scores over 28 aren't read/registered. With the addition of HotU and the epic Great (Ability Score) feats, someone that starts a half-orc with a 20 strength (18 base, +2 racial modifier) and only uses his ability score modifiers at every 4 levels would have a 30 strength at level 40, and the adding the Great (Ability Score) feat could reach a base of 40 if they took it 10 times. This sounds extreme, but it is possible.

Posted by Arminath at 2004-06-28 10:05:00

Is this compatible with 1.62? I'd like a way from keeping players to stack up on ability score bonuses and this seems great, but I'm patched up to 1.62.

Posted by Clarion de Laffalot ( ..xxx.xxx ) at 2004-03-21 11:33:00

Man, you don't have any idea how I've searched for some script like this!

I just ask why did Bioware never fix that...

Thanks a lot!

Posted by Old_Scores_Transfered at 2004-02-20 10:29:33 Voted 10.00 on 02/20/04

This is a compilation of the old system into a single score. There were 3 that made this score of 9.67 then rounded to 10.

Posted by YellowLab at 2004-01-16 20:35:00

I have updated the script set to 2.2

In this version the spells are now truly 1.61 compliant. I didn't add the spell cast hook scripts and some changes had been made to Bull's strength.

In addition, Divine Power has been added to the no stack list.

YL

Posted by YellowLab at 2004-01-08 20:51:00

Doh!
Meraxes, you are correct. I goofed. The functions should be as you state in your second message. I will correct the instructions. If you put those functions (the proper function calls :) ) into the module, the script set should work fine.

I apologize for the inconvinence.
Thanks for the catch.

YL

Posted by Meraxes at 2004-01-08 12:12:00

Aha! I think you might have a typo in your instructions..

You said to use:
"GetLastPCItemEquippedBy()"
"GetLastPCItemUnequippedBy()"

But I THINK you meant to say to use:
GetPCItemLastEquippedBy(), which is used for
// Use this to get the player character who last equipped an item in OnPlayerEquipItem..

and GetPCItemLastUnequippedBy()
// Use this to get the player character who last unequipped an item in OnPlayerUnEquipItem..

Both of which return a player object... Is this correct?

object

Posted by Meraxes at 2004-01-08 12:05:00

This is odd..
I just tried adding this to my world, but have a strange problem..

I do not seem to have two of your functions in my world... it's possible I have overwritten one of bioware's standard includes that now adds this but I can't seem to figure out which one..

Where would I find the following functions (required by your script)
"GetLastPCItemEquippedBy()"
and the corresponding
"GetLastPCItemUnequippedBy()"

Posted by YellowLab at 2004-01-03 21:33:00

Torias
Currently, the only things that this script set takes into consideration are ability enhancements (STR, INT, etc.) from items and spells (potions being a form of spells). One ring and one amulet of +2 INT when both are worn should not give a +4 to INT as they do with the Aurora engine. Rather, they should only give a +2 INT. This script set fixes those types of issues. Specific class abilities and feats that may cause ability enhancement haven't been looked at. The Aurora engine does a good job of not stacking armor class bonuses but fails in the stacking of ability enhancements.

Hope this answers your question.
YL

Posted by Torias. ( ..xxx.xxx ) at 2004-01-03 09:06:00

Given any thought to allowing some things to stack when they should be allowed to?

most notable is that barbarian rage and Dwarven Defender defencive stance bonuses should stack with magical bonuses, since they are different types.

Posted by NoMercy at 2004-01-02 19:11:00

Got slightly destracted, I'll probably put it up sometime this weekend if I can solve some bugs (started working on Keen Edge, and the (greater) Magic Weapon spells to bring them in-line with the D&D guide, few bugs to iron out those, but 4 spells fixed seems a bit more like a script than a few lines of code changed, might throw in improved invisibility which is currently about as good as normal invisibility.

For now it's 3am, and I should be in bed *grins*, any pointers to other broken spells would be handy though :)

Posted by YellowLab at 2004-01-02 14:18:00

NoMercy
Thanks for the heads up. I will take a look at the Divine Power spell. You are correct that there are no handles for this spell as I was unaware of how it worked.

The caster's strength should be taken to 18 which would be a +* where * is 18-Current Strength.

Once I get it done I will send it your way for testing and post here for all.

Thanks again.
YellowLab

Posted by NoMercy at 2004-01-02 13:13:00

Fantastic, just what I've been looking for, only thing I havn't seen is any hooks to Divine Power, the cleric spell which boosts the casters strength to 18, alas this is trivially exploited by casting/equiping items afterwards.

It should, I believe act as a minimum, say with 14 strength you cast divine power, you get 18 strength, equiping a +6 belt of strength should take you to 20 str, the default system I believe would take you to 24, not actually tested your scripts out yet, but I couln't see any hooks into divine power.

Seperately from this, I'm just about to upload a fix for Divine Power granting way to many extra attacks, I've definately counted 7 attacks with a single handed weapon with the current divine power *shudders*

Posted by YellowLab at 2004-01-01 18:49:00

I have updated this script set using the new script commands in version 1.60+ and all I can say is WOW!!! These new commands are awesome. Makes this script set much more efficient, more user friendly, and less noticable to the player.

Please download the file (the code window is merely the readme).

Enjoy.

YellowLab

Posted by YellowLab ( ..xxx.xxx ) at 2003-11-20 11:58:00

Once HotU comes out I will update / optimize this code with the new OnEquip / OnUnequip handles.

YL

Posted by YellowLab ( ..xxx.xxx ) at 2003-07-30 21:38:00

I hope my first comment in the description isn't scaring people away. I don't really know how CPU intensive they are. There are minimal cycles through equipped items, for this type of script there has to be. I haven't dealt much with multiplayer to know exactly how intense it is.

If someone could do some more definitive testing I would appreciate it.

Thanks.
YL

You must be Logged In to post comments in this section.