Skins: |

NWN SCRIPTS

- Jump to comments -

Title

CNR 3.05 Mineral Bath Fix

Author

Axe Murderer

Submitted / Updated

08-26-2007 / 08-26-2007

Category

Rulesets

Expansions

NWN-1.68

View Code

Fixed cnr_minbath_ou script -- version 1, following the comments (less lower quality gems)


/////////////////////////////////////////////////////////
//
//  Craftable Natural Resources (CNR) by Festyx
//
//  Name:  cnr_minbath_ou
//
//  Desc:  This is the OnUsed handler for Mineral Baths.
//         Mystery minerals found in its inventory are
//         converted to known gem minerals.
//
//         This OnUsed handler is meant to fix a Bioware
//         bug that sometimes prevents placeables from
//         getting OnOpen or OnClose events. This OnUsed
//         handler in coordination with the OnDisturbed
//         ("cnr_device_od") handler work around the bug.
//
//  Author: David Bobeck 07Apr03
//
/////////////////////////////////////////////////////////
//
// Bug fix. The distribution of gems in the original v3.05
// script does not match up with the random number being
// generated to make the determination of which gem is produced.
// It looks like somebody "fixed" the distribution to produce
// more lower quality gems but because the random number was
// not changed to match the alterations made in the big
// if-then-else statement, the result was that no very low
// quality gems like Greenstones would be produced at all.
// This version of it fixes the numbers in the if-statement
// conditionals to match the comments that are present.
// I suspect that these comments represent the initial design
// distribution, thus it probably returns the distribution
// back to its initial design (i.e. less lower quality gems).
//
// It was also modified to support stacked versions of the
// mystery mineral item, and to reduce the floating text spam
// by a third when large numbers of minerals are all washed at
// once.
// 
// Author: Axe Murderer Aug 26, 2007
//
/////////////////////////////////////////////////////////
#include "cnr_language_inc"
  
void main()
{
  // Note: A placeable will receive events in the following order...
  // OnOpen, OnUsed, OnDisturbed, OnClose, OnUsed.
  if (GetLocalInt(OBJECT_SELF, "bCnrDisturbed") != TRUE)
  {
    // Skip if the contents have not been altered.
    return;
  }
  
  SetLocalInt(OBJECT_SELF, "bCnrDisturbed", FALSE);
  
  // If the Bioware bug is in effect, simulate the closing
  if (GetIsOpen(OBJECT_SELF))
  {
    AssignCommand(OBJECT_SELF, ActionPlayAnimation(ANIMATION_PLACEABLE_CLOSE));
  }
  
  object oUser = GetLastUsedBy();
    
  int    iTotalMystery = 0;  // Keeps track of how many total minerals are being washed to reduce floating text spam.
  string sMineralTag = "cnrGemMineral001";
  object oItem = GetFirstItemInInventory(OBJECT_SELF);
  while (oItem != OBJECT_INVALID)
  {
    if (GetTag(oItem) == "cnrGemMineral000")
    {
      // destroy the mystery mineral
      DestroyObject(oItem);
      
      // get the stack size of the mystery mineral. If the item is not stackable this will be 1.
      int iStack = GetItemStackSize( oItem);
      
      // generate the washed minerals.
      int i = 0;
      for( i = 0; i < iStack; i++)
      { int nRand = Random(133)+1;
        if (nRand == 1) {sMineralTag = "cnrGemMineral012";}                           // 1
        else if ((nRand >= 2) && (nRand <= 3)) {sMineralTag = "cnrGemMineral006";}    // 2
        else if ((nRand >= 4) && (nRand <= 6)) {sMineralTag = "cnrGemMineral005";}    // 3
        else if ((nRand >= 7) && (nRand <= 10)) {sMineralTag = "cnrGemMineral009";}   // 4
        else if ((nRand >= 11) && (nRand <= 15)) {sMineralTag = "cnrGemMineral008";}  // 5
        else if ((nRand >= 16) && (nRand <= 23)) {sMineralTag = "cnrGemMineral010";}  // 8
        else if ((nRand >= 24) && (nRand <= 32)) {sMineralTag = "cnrGemMineral013";}  // 9
        else if ((nRand >= 33) && (nRand <= 42)) {sMineralTag = "cnrGemMineral011";}  // 10
        else if ((nRand >= 43) && (nRand <= 52)) {sMineralTag = "cnrGemMineral015";}  // 11
        else if ((nRand >= 53) && (nRand <= 64)) {sMineralTag = "cnrGemMineral003";}  // 12
        else if ((nRand >= 65) && (nRand <= 77)) {sMineralTag = "cnrGemMineral004";}  // 13
        else if ((nRand >= 78) && (nRand <= 90)) {sMineralTag = "cnrGemMineral014";}  // 13
        else if ((nRand >= 91) && (nRand <= 104)) {sMineralTag = "cnrGemMineral002";} // 14
        else if ((nRand >= 105) && (nRand <= 118)) {sMineralTag = "cnrGemMineral007";}// 14
        else {sMineralTag = "cnrGemMineral001";}                                      // 14
        //                                                                            //----
        //                                                                            //133
        object oMineral = CreateItemOnObject(sMineralTag, oUser, 1);
        string sFloat;
        int nFloat = d3(1);
        switch (nFloat)
        {
          case 1: {sFloat = CNR_TEXT_MINBATH_MUMBLE_1 + GetName(oMineral); break;}
          case 2: {sFloat = CNR_TEXT_MINBATH_MUMBLE_2 + GetName(oMineral); break;}
          default: {sFloat = CNR_TEXT_MINBATH_MUMBLE_3 + GetName(oMineral); break;}
        }
        
        // reduce the floating text spam by a third when there are more than 10 minerals being washed.
        ++iTotalMystery;
        if( (iTotalMystery <= 10) || ((iTotalMystery %3) == 0))
          FloatingTextStringOnCreature( sFloat, oUser, FALSE);
      }
    }
    oItem = GetNextItemInInventory(OBJECT_SELF);
  }
}
  
  
  
  
  
Fixed cnr_minbath_ou script -- version 2, based on the actual numbers present (more lower quality gems)


/////////////////////////////////////////////////////////
//
//  Craftable Natural Resources (CNR) by Festyx
//
//  Name:  cnr_minbath_ou
//
//  Desc:  This is the OnUsed handler for Mineral Baths.
//         Mystery minerals found in its inventory are
//         converted to known gem minerals.
//
//         This OnUsed handler is meant to fix a Bioware
//         bug that sometimes prevents placeables from
//         getting OnOpen or OnClose events. This OnUsed
//         handler in coordination with the OnDisturbed
//         ("cnr_device_od") handler work around the bug.
//
//  Author: David Bobeck 07Apr03
//
/////////////////////////////////////////////////////////
//
// Bug fix. The distribution of gems in the original v3.05
// script does not match up with the random number being
// generated to make the determination of which gem is produced.
// It looks like somebody "fixed" the distribution to produce
// more lower quality gems but because the random number was
// not changed to match the alterations made in the big
// if-then-else statement, the result was that no very low
// quality gems like Greenstones would be produced at all.
// This version of it fixes the random number to reflect the
// altered distribution number entered into the if-statement
// conditionals, and also changes the comments that are present
// to indicate what distribution of each gem will be generated.
// I suspect that these comments represented the initial design
// distribution, thus this script now matches up with the newer
// distribution numbers (i.e. more lower quality gems).
//
// It was also modified to support stacked versions of the
// mystery mineral item, and to reduce the floating text spam
// by a third when large numbers of minerals are all washed at
// once.
// 
// Author: Axe Murderer Aug 26, 2007
//
/////////////////////////////////////////////////////////
#include "cnr_language_inc"

void main()
{
  // Note: A placeable will receive events in the following order...
  // OnOpen, OnUsed, OnDisturbed, OnClose, OnUsed.
  if (GetLocalInt(OBJECT_SELF, "bCnrDisturbed") != TRUE)
  {
    // Skip if the contents have not been altered.
    return;
  }

  SetLocalInt(OBJECT_SELF, "bCnrDisturbed", FALSE);

  // If the Bioware bug is in effect, simulate the closing
  if (GetIsOpen(OBJECT_SELF))
  {
    AssignCommand(OBJECT_SELF, ActionPlayAnimation(ANIMATION_PLACEABLE_CLOSE));
  }

  object oUser = GetLastUsedBy();

  int    iTotalMystery = 0;  // Keeps track of how many total minerals are being washed to reduce floating text spam.
  string sMineralTag = "cnrGemMineral001";
  object oItem = GetFirstItemInInventory(OBJECT_SELF);
  while (oItem != OBJECT_INVALID)
  {
    if (GetTag(oItem) == "cnrGemMineral000")
    {
      // destroy the mystery mineral
      DestroyObject(oItem);
      
      // get the stack size of the mystery mineral. If the item is not stackable this will be 1.
      int iStack = GetItemStackSize( oItem);
      
      // generate the washed minerals.
      int i = 0;
      for( i = 0; i < iStack; i++)
      { int nRand = Random(155)+1;
        if (nRand == 1) {sMineralTag = "cnrGemMineral012";}                           //  1
        else if ((nRand >= 2) && (nRand <= 3)) {sMineralTag = "cnrGemMineral006";}    //  2
        else if ((nRand >= 4) && (nRand <= 6)) {sMineralTag = "cnrGemMineral005";}    //  3
        else if ((nRand >= 7) && (nRand <= 10)) {sMineralTag = "cnrGemMineral009";}   //  4
        else if ((nRand >= 11) && (nRand <= 15)) {sMineralTag = "cnrGemMineral008";}  //  5
        else if ((nRand >= 16) && (nRand <= 23)) {sMineralTag = "cnrGemMineral010";}  //  8
        else if ((nRand >= 24) && (nRand <= 32)) {sMineralTag = "cnrGemMineral013";}  //  9
        else if ((nRand >= 33) && (nRand <= 43)) {sMineralTag = "cnrGemMineral011";}  // 11
        else if ((nRand >= 44) && (nRand <= 55)) {sMineralTag = "cnrGemMineral015";}  // 12
        else if ((nRand >= 56) && (nRand <= 67)) {sMineralTag = "cnrGemMineral003";}  // 12
        else if ((nRand >= 68) && (nRand <= 90)) {sMineralTag = "cnrGemMineral004";}  // 23
        else if ((nRand >= 91) && (nRand <= 113)) {sMineralTag = "cnrGemMineral014";} // 23
        else if ((nRand >= 114) && (nRand <= 127)) {sMineralTag = "cnrGemMineral002";}// 14
        else if ((nRand >= 128) && (nRand <= 141)) {sMineralTag = "cnrGemMineral007";}// 14
        else {sMineralTag = "cnrGemMineral001";}                                      // 14
        //                                                                            //----
        //                                                                            //155
        object oMineral = CreateItemOnObject(sMineralTag, oUser, 1);
        string sFloat;
        int nFloat = d3(1);
        switch (nFloat)
        {
          case 1: {sFloat = CNR_TEXT_MINBATH_MUMBLE_1 + GetName(oMineral); break;}
          case 2: {sFloat = CNR_TEXT_MINBATH_MUMBLE_2 + GetName(oMineral); break;}
          default: {sFloat = CNR_TEXT_MINBATH_MUMBLE_3 + GetName(oMineral); break;}
        }
        
        // reduce the floating text spam by a third when there are more than 10 minerals being washed.
        ++iTotalMystery;
        if( (iTotalMystery <= 10) || ((iTotalMystery %3) == 0))
          FloatingTextStringOnCreature( sFloat, oUser, FALSE);
      }
    }
    oItem = GetNextItemInInventory(OBJECT_SELF);
  }
}

Select All Text | View Code in separate window

Format

Code Only

Type

Type - Other

Includes

Custom

Forums

Link

Description

I found a bug in the mineral bath placeable's OnUsed script in CNR v3.05. The bug prevents the bath from producing very low quality gems like Greenstones. I suspect that somewhere along the way somebody on the CNR team decided to change the distibution of gem quality that the bath produces and didn't implement it correctly. At least that is what it looks like to me based on the comments present in the script.

It was not real clear what the intent of the script was so I have made two versions of the script to fix it. One is based on the comments present in the script that I assume represent the original design for the gem quality distribution (i.e. less lower quality gems). The other is based on the actual numbers being used in the v3.05 script to generate the distribution (i.e. more lower quality gems).

I also added support for stacked mystery mineral items and a fix that reduces the floating text spam by a third when large numbers of minerals are all washed at once.

Files

Name	Type	Size	Downloads
NO FILES

SCORE OUT OF 10

10
2 votes
View Stats
Cast Your Vote!

PORTFOLIO

Add this entry to your portfolio so you can track it

Manage your existing portfolios or create a new one.

SCREENS

No Images

You Must Be Logged In to Participate.

Comments (2):

Posted by OnyxEye at 2007-09-08 13:50:15 Voted 10.00 on 09/08/07

Yes, thanks for the fix. I had wondered why the low quality gems weren't showing up, but just thought when I was testing that it was just randomly happening that way. :)

_________________________
OnyxEye - Lead Admin
The Realms of Ghamede
Link

Posted by Daijin at 2007-08-26 20:05:27 Voted 10.00 on 08/26/07

Thanks for the fix!
_________________________
Dream Well, Faith, Loyalty, Truth, Honor, Friendship always.....

Daijin Dreamweaver, Leader of the Dream Warriors for 32 years, going strong.

Nwn The Dunjon Shard:
Link

You must be Logged In to post comments in this section.